Fixes #35
Merged
Fixes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f484b04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for expressive-code-twoslash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
expressive-code-twoslashpackage, focusing on fixing line height issues and removing unused styles.Closes #30
Closes #31
Style Fixes and Improvements:
.changeset/metal-chefs-kick.md: Added a patch note to fix the line height size..changeset/wet-cups-rhyme.md: Added a patch note to remove an unused style that referenced Starlight.Codebase Updates:
packages/twoslash/src/styles.ts: Updated theline-heightproperty to use thecssVar("codeLineHeight")variable for better consistency and maintainability. [1] [2]packages/twoslash/src/styles.ts: Removed the fixedline-heightvalue from the.twoslash-popup-docsclass to use the variablecssVar("codeLineHeight")instead.packages/twoslash/src/styles.ts: Removed theline-height: 1emproperty from the.twoslash-completion-itemclass to align with the new variable-based approach.