Feature disable motion magic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ArmVisualizer into Arm Make sim work for Arm
Change Goal names
Move profile in to subsystem
jwbonner
requested changes
Feb 14, 2024
src/main/java/org/littletonrobotics/frc2024/RobotContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/RobotContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/RobotContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/Superstructure.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/Superstructure.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/Superstructure.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/arm/Arm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/arm/ArmVisualizer.java
Outdated
Show resolved
Hide resolved
|
Looks good, just make sure to fix those last couple of issues and we can get this merged. |
Visualizer working
jwbonner
requested changes
Feb 15, 2024
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/arm/Arm.java
Outdated
Show resolved
Hide resolved
Visualizer working
Compatible with custom user assets folder
|
I pushed a couple of fixes for the model, so it's just the |
jwbonner
requested changes
Feb 16, 2024
src/main/java/org/littletonrobotics/frc2024/subsystems/superstructure/arm/Arm.java
Outdated
Show resolved
Hide resolved
jwbonner
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved arm motion profile and the feedforward model into the subsystem. The IO layer only has to deal with controlling to the current setpoint.