Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interpolating tree map for calculating arm angle #16

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Use interpolating tree map for calculating arm angle #16

merged 2 commits into from
Feb 16, 2024

Conversation

suryatho
Copy link
Contributor

No description provided.

@suryatho suryatho linked an issue Feb 15, 2024 that may be closed by this pull request
Create arm angle lookup table #8
Closed
jwbonner
jwbonner previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jwbonner jwbonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now, though we should chat about whether the interpolation tables should be separated once there are multiple.

@jwbonner jwbonner dismissed camearle20’s stale review February 16, 2024 01:00

Changes were addressed

@jwbonner jwbonner merged commit 1505457 into main Feb 16, 2024
2 checks passed
@jwbonner jwbonner deleted the feature-arm-angle-lookup-table branch February 16, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwbonner jwbonner jwbonner approved these changes

@camearle20 camearle20 camearle20 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create arm angle lookup table
3 participants
@suryatho @camearle20 @jwbonner