Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is the event and eventview separation fine now? #67

Open
Olf0 opened this issue Oct 13, 2024 · 0 comments
Open

Question: Is the event and eventview separation fine now? #67

Olf0 opened this issue Oct 13, 2024 · 0 comments

Comments

@Olf0
Copy link
Member

Olf0 commented Oct 13, 2024

I wondered, if the separation (i.e. the conditional building) of the event and eventview sub-packages is working fine?
I.e., if the build conditions ([1], [2]) for these two sub-packages create appropriate results for the two build environments currently used: Coderus' Sailfish-SDK Docker-images for the CI/CD-workflow at GitHub and the SailfishOS-OBS. Side note: I expect that building locally with the Sailfish-SDK installed natively provides the same build environment as Coderus' Sailfish-SDK Docker-images.

I am positively surprised that my first take on this seem to work perfectly, which is better than expected, because I never took a look at the build environment (specifically the macros set) inside the Sailfish-SDK.
When looking at the results of a recent CI/CD run, I see that both event and eventview sub-packages are built, which indicates that the RPM-macro sailfishos_version is not defined inside the Sailfish-SDK.

Thus it appears to be sufficient to use the existence of the RPM-macro sailfishos_version as a differentiator for building either at the SailfishOS-OBS or elsewhere (which is the status quo).

Side note: I opened issue #68, because this is currently not utilised as intended. I will leave this issue open until issue #68 is resolved, so we can properly discuss general aspects (here, i.e. #67) and OpenRepos-specific aspects (in #68) separately.


For documentation only

Meanwhile I considered which other macros could be used as such differentiators and remembered that I already performed this research a while ago in a different context: sailfishos-chum/sailfishos-chum-gui#149 (comment)

If ever needed, these could alternatively used as differentiators for building either at the SailfishOS-OBS or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant