You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wondered, if the separation (i.e. the conditional building) of the event and eventview sub-packages is working fine?
I.e., if the build conditions ([1], [2]) for these two sub-packages create appropriate results for the two build environments currently used: Coderus' Sailfish-SDK Docker-images for the CI/CD-workflow at GitHub and the SailfishOS-OBS. Side note: I expect that building locally with the Sailfish-SDK installed natively provides the same build environment as Coderus' Sailfish-SDK Docker-images.
I am positively surprised that my first take on this seem to work perfectly, which is better than expected, because I never took a look at the build environment (specifically the macros set) inside the Sailfish-SDK.
When looking at the results of a recent CI/CD run, I see that both event and eventview sub-packages are built, which indicates that the RPM-macro sailfishos_version is not defined inside the Sailfish-SDK.
Thus it appears to be sufficient to use the existence of the RPM-macro sailfishos_version as a differentiator for building either at the SailfishOS-OBS or elsewhere (which is the status quo).
Side note: I opened issue #68, because this is currently not utilised as intended. I will leave this issue open until issue #68 is resolved, so we can properly discuss general aspects (here, i.e. #67) and OpenRepos-specific aspects (in #68) separately.
For documentation only
Meanwhile I considered which other macros could be used as such differentiators and remembered that I already performed this research a while ago in a different context: sailfishos-chum/sailfishos-chum-gui#149 (comment)
I wondered, if the separation (i.e. the conditional building) of the
event
andeventview
sub-packages is working fine?I.e., if the build conditions ([1], [2]) for these two sub-packages create appropriate results for the two build environments currently used: Coderus' Sailfish-SDK Docker-images for the CI/CD-workflow at GitHub and the SailfishOS-OBS. Side note: I expect that building locally with the Sailfish-SDK installed natively provides the same build environment as Coderus' Sailfish-SDK Docker-images.
I am positively surprised that my first take on this seem to work perfectly, which is better than expected, because I never took a look at the build environment (specifically the macros set) inside the Sailfish-SDK.
When looking at the results of a recent CI/CD run, I see that both
event
andeventview
sub-packages are built, which indicates that the RPM-macrosailfishos_version
is not defined inside the Sailfish-SDK.Thus it appears to be sufficient to use the existence of the RPM-macro
sailfishos_version
as a differentiator for building either at the SailfishOS-OBS or elsewhere (which is the status quo).Side note: I opened issue #68, because this is currently not utilised as intended. I will leave this issue open until issue #68 is resolved, so we can properly discuss general aspects (here, i.e. #67) and OpenRepos-specific aspects (in #68) separately.
For documentation only
Meanwhile I considered which other macros could be used as such differentiators and remembered that I already performed this research a while ago in a different context: sailfishos-chum/sailfishos-chum-gui#149 (comment)
%_project
and%_repository
are specifically set by OBS (i.e. should not be defined when building elsewhere).Side note: Jolla sets them again in their DoD-repo configs as RPM-macros (while un-setting does not work in my experience, overwriting / redefining does) and additionally as
%define
s (ugh, "overwrite" a RPM-macro by a spec file local%define
; I wonder if the behaviour for this is specified).%_chum
is only set for the SailishOS-OBS repositoriesSailfishOS:Chum
andSailfishOS:Chum:Testing
(or OBS-repos trying to mimic these).If ever needed, these could alternatively used as differentiators for building either at the SailfishOS-OBS or not.
The text was updated successfully, but these errors were encountered: