Merge Space Templates - Meeds-io/MIPs#150 #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/MIPs#150 (#2489) This change will Modify the pages definition to use 'social' instead of 'social-portlet' to reference the Social Module portlets. See Meeds-io/social@9e0766a for more information about this change. A dedicated configuration to upgrade the existing pages has been added to upgrade the existing pages to reference the new Webapp Module instead of deleted 'social-portlet' module.
…-7638 - Meeds-io/MIPs#150 This change will delete the old definition of Space Templates in order to introduce a new one. In addition, this change will delete the Space Menu and Header portlets in favor of Space Banner Portlet knowing that the topbar navigation will be defined from now on in Shared layout.
This change will allow to access space 'SYSTEM' pages even when the Space site doesn't define it. The system pages are 'tasks', 'notes', 'members' and 'settings'.
boubaker
force-pushed
the
merge-mip-150
branch
from
8e6586c
to
1c7aab6
Compare
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
rdenarie
approved these changes
Nov 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#150