Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix wallet association for same address - MEED-2318 #394

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

boubaker
Copy link
Member

Prior to this change, two users wa able to use the same address for their Wallet. This change ensures to not have such a possible wallet association by adding a proper Alert message when doing so.
In addition, this change will fix Mail Notification Footer creation with missing 'COMPANY_LINK' variable.
In addition, this change will ensure to delete nonce of dropped transactions (New feature used to replace/resend transactions) to ensure to not have a not recognized nonce in blockchain.

Prior to this change, two users wa able to use the same address for their Wallet. This change ensures to not have such a possible wallet association by adding a proper Alert message when doing so.
In addition, thsic hange will fix Mail Notification Footer creation with missing 'COMPANY_LINK' variable.
In addition, this change will ensure to delete nonce of dropped transactions (New feature used to replace/resend transactions) to ensure to not have a not recognized nonce in blockchain.
@boubaker boubaker merged commit 3ea4eb5 into feature/meedsv2 Jul 26, 2023
@boubaker boubaker deleted the meed-2318 branch July 26, 2023 07:58
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
7.8% 7.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

boubaker added a commit that referenced this pull request Jul 26, 2023
Prior to this change, two users wa able to use the same address for
their Wallet. This change ensures to not have such a possible wallet
association by adding a proper Alert message when doing so.
In addition, this change will fix Mail Notification Footer creation with
missing 'COMPANY_LINK' variable.
In addition, this change will ensure to delete nonce of dropped
transactions (New feature used to replace/resend transactions) to ensure
to not have a not recognized nonce in blockchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant