feat: Fix walletSettings extension registry ranking in spaceSettings list - EXO-69808 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rdenarie
requested changes
Feb 26, 2024
rdenarie
requested changes
Feb 26, 2024
There was a problem hiding this comment.
In addition, I'm not sure the problem is the ranking but the fact that, even if the extension have nothing to display in a space, the margin is generated.
If the extension have nothing to display, it should not generate any html, which result in not displaying the margin.
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
f8ebf6c
to
b6a430e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the display ranking for walletSettings extension registry in spaceSettings extension list.