Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Meeds-io/MIPs#150 - Dev Meed #603

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Merge Meeds-io/MIPs#150 - Dev Meed #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9113046
feat: Update Space URL computing - Meeds-io/MIPs#150
boubaker Oct 20, 2024
aa51856
feat: Delete SpaceService.getSpaceByUrl API - Meeds-io/MIPs#150
boubaker Oct 21, 2024
fffbd06
feat: Delete Space.getSpaceByDisplayName API - Meeds-io/MIPs#150
boubaker Oct 21, 2024
e1ab8e2
feat: Replace StringUtils package name - Meeds-io/MIPs#150
boubaker Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions wallet-api/src/main/java/io/meeds/wallet/utils/WalletUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,13 +489,7 @@ public static Space getSpace(String id) {
if (space == null) {
space = spaceService.getSpaceByGroupId("/spaces/" + id);
if (space == null) {
space = spaceService.getSpaceByDisplayName(id);
if (space == null) {
space = spaceService.getSpaceByUrl(id);
if (space == null) {
space = spaceService.getSpaceById(id);
}
}
space = spaceService.getSpaceById(id);
}
}
return space;
Expand Down
2 changes: 1 addition & 1 deletion ...vices/src/main/java/io/meeds/wallet/reward/notification/RewardSuccessTemplateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import io.meeds.common.ContainerTransactional;
import io.meeds.wallet.model.RewardSettings;
import io.meeds.wallet.reward.service.RewardSettingsService;
import org.apache.commons.codec.binary.StringUtils;
import org.apache.commons.lang3.StringUtils;

import org.exoplatform.commons.api.notification.NotificationContext;
import org.exoplatform.commons.api.notification.channel.template.AbstractTemplateBuilder;
Expand Down
2 changes: 1 addition & 1 deletion ...ices/src/main/java/io/meeds/wallet/reward/notification/RewardSuccessTemplateProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import io.meeds.wallet.reward.service.RewardSettingsService;
import lombok.Getter;
import lombok.Setter;
import org.apache.commons.codec.binary.StringUtils;
import org.apache.commons.lang3.StringUtils;

import org.exoplatform.commons.api.notification.channel.template.TemplateProvider;
import org.exoplatform.commons.api.notification.model.ChannelKey;
Expand Down
7 changes: 1 addition & 6 deletions wallet-services/src/main/java/io/meeds/wallet/permlink/plugin/WalletPermanentLinkPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,7 @@ public String getDirectAccessUrl(PermanentLinkObject object) throws ObjectNotFou
}

public String getSpaceUrl(Space space) {
StringBuilder spaceUrl = new StringBuilder("/portal/g/");
spaceUrl.append(space.getGroupId().replace("/", ":"))
.append("/")
.append(space.getPrettyName())
.append("/SpaceWallet");
return spaceUrl.toString();
return String.format("/portal/s/%s/SpaceWallet", space.getId());
}

public String getProfileUrl() {
Expand Down
2 changes: 1 addition & 1 deletion wallet-services/src/test/java/io/meeds/wallet/test/mock/IdentityManagerMock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import java.util.ArrayList;
import java.util.List;

import org.apache.commons.codec.binary.StringUtils;
import org.apache.commons.lang3.StringUtils;

import org.exoplatform.commons.utils.ListAccess;
import org.exoplatform.social.core.identity.IdentityProvider;
Expand Down