-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy configuration daemon via reconcilation of the NicConfigurationTemplate #55
Conversation
c06e6b0
to
5a8c395
Compare
Pull Request Test Coverage Report for Build 12428414078Details
💛 - Coveralls |
5a8c395
to
96fb01c
Compare
e7ba78e
to
134800f
Compare
labels: | ||
app.kubernetes.io/name: nic-configuration-daemon | ||
app.kubernetes.io/created-by: nic-configuration-operator | ||
app.kubernetes.io/part-of: nic-configuration-operator | ||
{{- include "nic-configuration-operator.labels" . | nindent 4 }} | ||
annotations: | ||
release.openshift.io/version: "{{.ReleaseVersion}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to apply openshift-specific annotation always?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't but it doesn't affect the vanilla deployments by having those annotations. Let's address it when introducing a NicConfigurationOperatorConfig CRD in the future. I've added a note to the #56 not to forget it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm the previous comment, added the "clusterType" parameter to config and now the openshift annotations are added conditionally
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
134800f
to
cedb2e3
Compare
This change is required for OCP support.
OCP bundle cannot deploy multiple entities, thus we need to make config daemon deployment manageable from the operator itself. The daemon related helm chart parameters are propagated as env variables to the operator container, the manifest is injected into the docker image.
When NicConfigurationTemplate is being reconciled, the same controller will also synchronize the config daemon ds.
This PR only introduces changes to code and helm chart. kustomize and OCP bundle changes will come in a separate PR.
Questions for reviewers: