Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema updates #73

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

nickolasclarke
Copy link
Contributor

@nickolasclarke nickolasclarke commented Apr 26, 2024

Resolves #72 and addresses some other missing fields along the way. See a list of the errors of missing fields I collected from the logs after fixing the schema issue with events.

Curiously, some of the missing fields do not appear in the 2023-10-15 API revision docs, nor do I see them in the latest revision docs. Those which did not appear I removed. This included profiles.attributes.anonymous_id,metrics.attributes.integration.object', and 'metrics.attributes.integration.key and a few others.

I am most interested in fixing the events schema and while I eyeballed the results for the others, please feel free to further validate. I am also unclear on styling conventions. Feel free to edit as needed.

Properties ('type', 'attributes.audiences', 'attributes.send_options', 'attributes.tracking_options', 'attributes.send_strategy', 'relationships', 'links', 'filter') were present in the 'campaigns' stream but not found in catalog schema. Ignoring. 
Properties ('relationships', 'links') were present in the 'flows' stream but not found in catalog schema. Ignoring. 
Properties ('type', 'attributes.opt_in_process', 'relationships', 'links') were present in the 'lists' stream but not found in catalog schema. Ignoring.
Properties ('type', 'attributes.integration.object', 'attributes.integration.key', 'links') were present in the 'metrics' stream but not found in catalog schema. Ignoring.
Properties ('attributes.anonymous_id', 'attributes.location.ip', 'relationships', 'links') were present in the 'profiles' stream but not found in catalog schema. Ignoring.
Properties ('links',) were present in the 'templates' stream but not found in catalog schema. Ignoring.

@nickolasclarke nickolasclarke marked this pull request as draft April 26, 2024 04:03
@nickolasclarke nickolasclarke changed the title Schema updates WIP Schema updates Apr 26, 2024
@nickolasclarke nickolasclarke marked this pull request as ready for review April 26, 2024 16:15
@nickolasclarke
Copy link
Contributor Author

@edgarrmondragon feel free to review at this point.

@nickolasclarke nickolasclarke changed the title WIP Schema updates fix: schema updates Apr 26, 2024
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nickolasclarke.

@edgarrmondragon edgarrmondragon merged commit fabc5fd into MeltanoLabs:main Apr 29, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events stream missing relationship attributes
2 participants