Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add json_as_object option #526

Merged
merged 3 commits into from
Nov 1, 2024
Merged

feat: Add json_as_object option #526

merged 3 commits into from
Nov 1, 2024

Conversation

joncass
Copy link
Contributor

@joncass joncass commented Nov 1, 2024

To allow JSON and JSONB to be tapped as plain objects

See this Slack thread for context

@joncass joncass changed the title Add json_as_object option to allow JSON and JSONB to be tapped as plain objects feat: Add json_as_object option Nov 1, 2024
Copy link
Member

@visch visch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I can approve as is, just a nit pick!

tests/test_core.py Outdated Show resolved Hide resolved
@joncass joncass requested a review from visch November 1, 2024 14:29
@visch visch merged commit 6efa7d0 into MeltanoLabs:main Nov 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants