Reversed elements in a faster way.

MeltyPlayer · Jul 9, 2024 · 9a45e71 · 9a45e71
1 parent 1804b7d
commit 9a45e71
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 6 deletions.
diff --git a/Benchmarks/Benchmarks.csproj b/Benchmarks/Benchmarks.csproj
@@ -8,7 +8,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="BenchmarkDotNet" Version="0.13.8" />
+    <PackageReference Include="BenchmarkDotNet" Version="0.13.12" />
+    <PackageReference Include="CommunityToolkit.HighPerformance" Version="8.2.0" />
     <PackageReference Include="ZString" Version="2.5.1" />
   </ItemGroup>
 

diff --git a/Benchmarks/Main.cs b/Benchmarks/Main.cs
@@ -1,12 +1,14 @@
 using BenchmarkDotNet.Configs;
+using BenchmarkDotNet.Diagnosers;
 using BenchmarkDotNet.Running;
 
 namespace benchmarks {
   public class Program {
     public static void Main(string[] args) {
-      var summary = BenchmarkRunner.Run<StringBuilderComparison>(
+      var summary = BenchmarkRunner.Run<ReadingValues>(
           ManualConfig
               .Create(DefaultConfig.Instance)
+              .AddDiagnoser(new MemoryDiagnoser(new MemoryDiagnoserConfig(true)))
               .WithOptions(ConfigOptions.DisableOptimizationsValidator));
     }
   }

diff --git a/Schema/Schema.csproj b/Schema/Schema.csproj
@@ -35,7 +35,8 @@
 
   <ItemGroup>
     <!-- Generator dependencies -->
-    <PackageReference Include="CommunityToolkit.HighPerformance" Version="8.2.0" GeneratePathProperty="true" PrivateAssets="all" />
+    <PackageReference Include="CommunityToolkit.HighPerformance" Version="8.2.2" GeneratePathProperty="true" PrivateAssets="all" />
+    <PackageReference Include="Tedd.BitUtils" Version="1.0.7" />
   </ItemGroup>
 
   <PropertyGroup>

diff --git a/Schema/src/binary/reader/EndianBinaryBufferedStream.cs b/Schema/src/binary/reader/EndianBinaryBufferedStream.cs
@@ -1,11 +1,14 @@
 using System;
+using System.Buffers.Binary;
 using System.Runtime.CompilerServices;
 
 using CommunityToolkit.HighPerformance;
 
 using schema.src.util;
 using schema.util.streams;
 
+using Tedd;
+
 namespace schema.binary {
   public interface ISpanElementReverser {
     void Reverse(Span<byte> span);
@@ -15,9 +18,33 @@ public interface ISpanElementReverser {
   public class SpanElementReverser : ISpanElementReverser {
     public void Reverse(Span<byte> span) => span.Reverse();
 
-    public void ReverseElements(Span<byte> span, int stride) {
-      for (var i = 0; i < span.Length; i += stride) {
-        span.Slice(i, stride).Reverse();
+    public void ReverseElements(Span<byte> bytes, int stride) {
+      if (stride == 2) {
+        var shorts = bytes.Cast<byte, short>();
+        for (var i = 0; i < shorts.Length; ++i) {
+          shorts[i].ReverseEndianness();
+        }
+        return;
+      }
+
+      if (stride == 4) {
+        var ints = bytes.Cast<byte, int>();
+        for (var i = 0; i < ints.Length; ++i) {
+          ints[i].ReverseEndianness();
+        }
+        return;
+      }
+
+      if (stride == 8) {
+        var longs = bytes.Cast<byte, long>();
+        for (var i = 0; i < longs.Length; ++i) {
+          longs[i].ReverseEndianness();
+        }
+        return;
+      }
+
+      for (var i = 0; i < bytes.Length; i += stride) {
+        bytes.Slice(i, stride).Reverse();
       }
     }
   }