Cleaned up diagnostic reporting by introducing a new type explicitly …

…for this.
MeltyPlayer · Aug 2, 2023 · dbf70cf · dbf70cf
1 parent cfd1d4d
commit dbf70cf
Show file tree

Hide file tree

Showing 20 changed files with 285 additions and 261 deletions.
diff --git a/Schema Tests/BinarySchemaTestUtil.cs b/Schema Tests/BinarySchemaTestUtil.cs
@@ -81,8 +81,7 @@ or StructDeclarationSyntax
                          var namedTypeSymbol = symbol as INamedTypeSymbol;
 
                          return new BinarySchemaStructureParser()
-                             .ParseStructure(
-                                 namedTypeSymbol);
+                             .ParseStructure(namedTypeSymbol);
                        })
                        .ToArray();
 
@@ -116,7 +115,7 @@ or StructDeclarationSyntax
     }
 
     public static void AssertDiagnostics(
-        IList<Diagnostic> actualDiagnostics,
+        IReadOnlyList<Diagnostic> actualDiagnostics,
         params DiagnosticDescriptor[] expectedDiagnostics) {
       var message = "";
 

diff --git a/Schema/src/binary/BinarySchemaAnalyzer.cs b/Schema/src/binary/BinarySchemaAnalyzer.cs
@@ -93,13 +93,7 @@ public void CheckType(
           return;
         }
 
-        var structure = this.parser_.ParseStructure(symbol);
-        var diagnostics = structure.Diagnostics;
-        if (diagnostics.Count > 0) {
-          foreach (var diagnostic in diagnostics) {
-            Rules.ReportDiagnostic(context, diagnostic);
-          }
-        }
+        this.parser_.ParseStructure(symbol, context);
       } catch (Exception exception) {
         if (Debugger.IsAttached) {
           throw;