MeshTopology::collapseEdge(...) #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedr
changed the title
Grantim
approved these changes
Nov 1, 2024
source/MRMesh/MRMeshTopology.h
Outdated
| /// collapses given edge in a vertex and deletes | ||
| /// 1) faces: left( e ) and right( e ); | ||
| /// 2) vertex org( e )/dest( e ) if given edge was their only edge, otherwise only dest( e ); | ||
| /// 3) edges: e, next( e.sym() ), prev( e.sym() ), and optionally next( e ), prev( e ) if their left and right triangles are deleted; |
There was a problem hiding this comment.
change edges and vertes? (if we delete optional edges from (3) then we should also delete optional org(e) from (2))?
source/MRMesh/MRMeshTopology.h
Outdated
| /// 1) faces: left( e ) and right( e ); | ||
| /// 2) vertex org( e )/dest( e ) if given edge was their only edge, otherwise only dest( e ); | ||
| /// 3) edges: e, next( e.sym() ), prev( e.sym() ), and optionally next( e ), prev( e ) if their left and right triangles are deleted; | ||
| /// calls onEdgeDel for every deleted edge (del); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collapseEdgefunction inMRMeshDecimate.cppbecomes public method ofMeshTopologystd::functionoptional parameter, all other updates can be implemented via itDecimateSettings::edgesToCollapseis updated during decimation.