Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

deps: @metamask/eth-hd-keyring@^6.0.0->^7.0.1 #275

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

legobeat
Copy link
Contributor

Description

  • deps: Bump @metamask/eth-hd-keyring from ^6.0.0 to ^7.0.1

Changes

  • Changed: Bump @metamask/eth-hd-keyring from ^6.0.0 to ^7.0.1

References

Resolves

Blocking

Related:

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat legobeat marked this pull request as ready for review September 26, 2023 22:33
@legobeat legobeat requested a review from a team as a code owner September 26, 2023 22:33
@legobeat legobeat added the type-dependencies Pull requests that update a dependency file label Sep 26, 2023
@socket-security
Copy link

socket-security bot commented Sep 26, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-hd-keyring 6.0.2...7.0.1 None +0/-9 59.7 kB metamaskbot

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/eth-hd-keyring@7.0.1

@jiexi
Copy link

jiexi commented Oct 2, 2023

Unrelated. Looks like @ethereumjs/wallet 2.0.0 introduces a new @ethereumjs/util version

jiexi@1200775 ~/P/KeyringController ((013d97f1))> yarn why @ethereumjs/util
├─ @ethereumjs/common@npm:3.2.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @ethereumjs/tx@npm:4.2.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @ethereumjs/wallet@npm:2.0.0
│  └─ @ethereumjs/util@npm:9.0.0 [6d0b6] (via npm:^9.0.0 [6d0b6])
│
├─ @metamask/eth-hd-keyring@npm:7.0.1
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @metamask/eth-sig-util@npm:5.1.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.0.6)
│
├─ @metamask/eth-sig-util@npm:7.0.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
└─ @metamask/eth-simple-keyring@npm:5.0.0
   └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.0.0)

jiexi
jiexi previously approved these changes Oct 2, 2023
@legobeat
Copy link
Contributor Author

legobeat commented Oct 2, 2023

Unrelated. Looks like @ethereumjs/wallet 2.0.0 introduces a new @ethereumjs/util version

jiexi@1200775 ~/P/KeyringController ((013d97f1))> yarn why @ethereumjs/util
├─ @ethereumjs/common@npm:3.2.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @ethereumjs/tx@npm:4.2.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @ethereumjs/wallet@npm:2.0.0
│  └─ @ethereumjs/util@npm:9.0.0 [6d0b6] (via npm:^9.0.0 [6d0b6])
│
├─ @metamask/eth-hd-keyring@npm:7.0.1
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
├─ @metamask/eth-sig-util@npm:5.1.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.0.6)
│
├─ @metamask/eth-sig-util@npm:7.0.0
│  └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.1.0)
│
└─ @metamask/eth-simple-keyring@npm:5.0.0
   └─ @ethereumjs/util@npm:8.1.0 (via npm:^8.0.0)

This should OK since here it's a devDependency only used in tests, though the runtime version will eventually get here too after the same has first been done in eth-sig-util and the keyrings.

@legobeat
Copy link
Contributor Author

legobeat commented Oct 2, 2023

@jiexi Rebased on main and resolved yarn.lock conflicts after merge of #273

Copy link

@jiexi jiexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@legobeat legobeat merged commit 256c540 into MetaMask:main Oct 2, 2023
16 checks passed
@legobeat legobeat mentioned this pull request Jan 18, 2024
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants