Skip to content

Commit

Permalink
Run linting and testing GitHub workflows on PRs
Browse files Browse the repository at this point in the history
Currently, code is not automatically linted and tests are not
automatically run on pull requests. This happens because the workflows
which would perform these steps are not configured to run on pull
requests but only on a push to `main`. This PR modifies the workflows to
run on the `pull_request` event.
  • Loading branch information
mcmire committed Mar 14, 2024
1 parent 7c7f7d6 commit 54a3149
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/shellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ name: shellcheck
permissions:
checks: write

on: [push]
on:
push:
branches: [main]
pull_request:

jobs:
lint:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-monorepo.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: test-monorepo
on: [push]
on:
push:
branches: [main]
pull_request:
jobs:
# test npm publish dry-run
checkout_publish_skunkworks_dry_run:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-polyrepo.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: test-polyrepo
on: [push]
on:
push:
branches: [main]
pull_request:
jobs:
# test npm publish dry-run
checkout_publish_controllers_dry_run:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: test
on: [push]
on:
push:
branches: [main]
pull_request:
jobs:
test:
runs-on: ubuntu-20.04
Expand Down

0 comments on commit 54a3149

Please sign in to comment.