From d686366c1f697d309418d3412d8ad78ead667bf3 Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Tue, 7 May 2024 09:39:33 -0600 Subject: [PATCH] Don't fail overall if Slack announcement fails Typically, for a project, this action is run twice: once in dry-run mode (to allow approvers to review the package before it is published) and another time to issue the approval step and then actually publish the package. When the action is run in dry-run mode, an announcement on Slack is created in order to notify approvers. If this fails in any way, however, it halts the release workflow completely and prevents the second instance of the action from running. This means that the package can never be released automatically and must be released manually. This commit fix this problem by instructing GitHub Actions that it is not mandatory for the Slack announcement step to pass in order for the release workflow to continue. --- action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/action.yml b/action.yml index 56f091b..8699454 100644 --- a/action.yml +++ b/action.yml @@ -83,3 +83,4 @@ runs: env: SLACK_WEBHOOK_URL: ${{ inputs.slack-webhook-url }} SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK + continue-on-error: true