Run linting and testing GitHub workflows on PRs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
run-workflows-on-prs
branch
from
23f29aa
to
42e5932
Compare
Currently, code is not automatically linted and tests are not automatically run on pull requests. This happens because the workflows which would perform these steps are not configured to run on pull requests but only on a push to `main`. This PR modifies the workflows to run on the `pull_request` event.
mcmire
force-pushed
the
run-workflows-on-prs
branch
from
42e5932
to
54a3149
Compare
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
* origin/main: remove default channel (#73) Don't fail overall if Slack announcement fails (#69) Improve Dry Run Output (#64) 5.0.0 (#67) Fix Yarn 4 compatibility (#65) Disallow publishing packages with version 0.0.0 (#63) Run linting and testing GitHub workflows on PRs (#62) Enabling MetaMask security code scanner (#60) Add Shared Libraries team in codeowners file (#59) Update README.md (#56) Update README.md (#55) Update README.md (#54) Bump word-wrap from 1.2.3 to 1.2.4 (#53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, code is not automatically linted and tests are not automatically run on pull requests. This happens because the workflows which would perform these steps are not configured to run on pull requests but only on a push to
main. This PR modifies the workflows to run on thepull_requestevent.