-
-
Notifications
You must be signed in to change notification settings - Fork 185
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: update transaction controllers to use selected account (#4244)
This pr updates the transaction controller to use account id from the InternalAccount instead of an address Related to MetaMask/accounts-planning#381 - **BREAKING**: `getSelectedAddress` is replaced with `getSelectedAccount` in the `TransactionController` - **BREAKING**: `getCurrentAccount` returns an `InternalAccount` instead of a `string` in the `IncomingTransactionHelper` - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate Fixes MetaMask/accounts-planning#381 --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
- Loading branch information
Showing
9 changed files
with
245 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.