Skip to content

Commit

Permalink
fix: add useSafeChainsListValidation && useMultiRpcMigration
Browse files Browse the repository at this point in the history
  • Loading branch information
salimtb committed Sep 25, 2024
1 parent e52002e commit 8cce274
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 0 deletions.
14 changes: 14 additions & 0 deletions packages/preferences-controller/src/PreferencesController.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ describe('PreferencesController', () => {
showTestNetworks: false,
isIpfsGatewayEnabled: true,
useTransactionSimulations: true,
useSafeChainsListValidation: true,
useMultiRpcMigration: true,
showIncomingTransactions: Object.values(
ETHERSCAN_SUPPORTED_CHAIN_IDS,
).reduce((acc, curr) => {
Expand Down Expand Up @@ -368,6 +370,18 @@ describe('PreferencesController', () => {
);
});

it('should set useSafeChainsListValidation', () => {
const controller = setupPreferencesController();
controller.setUseSafeChainsListValidation(true);
expect(controller.state.useSafeChainsListValidation).toBe(true);
});

it('should set useMultiRpcMigration', () => {
const controller = setupPreferencesController();
controller.setUseMultiRpcMigration(true);
expect(controller.state.useMultiRpcMigration).toBe(true);
});

it('should set featureFlags', () => {
const controller = setupPreferencesController();
controller.setFeatureFlag('Feature A', true);
Expand Down
40 changes: 40 additions & 0 deletions packages/preferences-controller/src/PreferencesController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ export type PreferencesState = {
* Controls whether transaction simulations are enabled
*/
useTransactionSimulations: boolean;
/**
* Controls whether Multi rpc modal is displayed or not
*/
useMultiRpcMigration: boolean;
/**
* Controls whether chain validation is enabled or not
*/
useSafeChainsListValidation: boolean;
};

const metadata = {
Expand All @@ -128,6 +136,8 @@ const metadata = {
useTokenDetection: { persist: true, anonymous: true },
smartTransactionsOptInStatus: { persist: true, anonymous: false },
useTransactionSimulations: { persist: true, anonymous: true },
useMultiRpcMigration: { persist: true, anonymous: true },
useSafeChainsListValidation: { persist: true, anonymous: true },
};

const name = 'PreferencesController';
Expand Down Expand Up @@ -197,6 +207,8 @@ export function getDefaultPreferencesState() {
showTestNetworks: false,
useNftDetection: false,
useTokenDetection: true,
useMultiRpcMigration: true,
useSafeChainsListValidation: true,
smartTransactionsOptInStatus: false,
useTransactionSimulations: true,
};
Expand Down Expand Up @@ -483,6 +495,34 @@ export class PreferencesController extends BaseController<
}
}

/**
* Toggle the use safe chains list validation.
*
* @param useSafeChainsListValidation - Boolean indicating user preference on using chainid.network third part to check safe networks.
*/
setUseSafeChainsListValidation(useSafeChainsListValidation: boolean) {
this.update((state) => {
state.useSafeChainsListValidation = useSafeChainsListValidation;
if (!useSafeChainsListValidation) {
state.useSafeChainsListValidation = false;
}
});
}

/**
* Toggle multi rpc migration modal.
*
* @param useMultiRpcMigration - Boolean indicating if the multi rpc modal will be displayed or not.
*/
setUseMultiRpcMigration(useMultiRpcMigration: boolean) {
this.update((state) => {
state.useMultiRpcMigration = useMultiRpcMigration;
if (!useMultiRpcMigration) {
state.useMultiRpcMigration = false;
}
});
}

/**
* A setter for the user to opt into smart transactions
*
Expand Down

0 comments on commit 8cce274

Please sign in to comment.