GasFeeController: providerConfig -> selectedNetworkClientId #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in GasFeeController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`.
3 tasks
ccharly
added a commit
that referenced
this pull request
Jul 3, 2024
## Explanation Create release for: - `@metamask/accounts-controller` to ^17.2.0 - `@metamask/gas-fee-controller` to ^18.0.0 - `@metamask/transaction-controller` to ^34.0.0 - `@metamask/user-operation-controller` to ^13.0.0 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/accounts-controller` - **ADDED**: `accountAdded` and `accountRemoved` events ([#4496](#4496)) - **ADDED**: Export `AccountsControllerListMultichainAccounts`,`AccountsControllerGetSelectedMultichainAccount`,`AccountsControllerGetNextAvailableAccountName}Action` actions ([#4497](#4497)) - **FIXED**: Use `listMultichainAccounts` for non-EVM specific methods. ([#4494](#4494)) - **FIXED**: Set `lastSelected` for initial account ([#4494](#4494)) ### `@metamask/gas-fee-controller` - **BREAKING**: Added back the constructor options legacyAPIEndpoint and EIP1559APIEndpoint. These URLs are no longer hardcoded within the controller. - **BREAKING**: Removed the infuraAPIKey. This was used to construct and send the Authorization header for Infura gas API requests. ([#4446](#4446)) - **CHANGED**: Changing `providerConfig` to `selectedNetworkClientId` ([#4356](#4356)) - ### `@metamask/user-operation-controller` - **BREAKING:** Bump dependency and peer dependency `@metamask/gas-fee-controller` to `^18.0.0` ([#4498](#4498)) - **BREAKING:** Bump dependency and peer dependency `@metamask/transaction-controller` to `^34.0.0` ([#4498](#4498)) - ### `@metamask/transaction-controller` - **BREAKING:** Bump dependency and peer dependency `@metamask/gas-fee-controller` to `^18.0.0` ([#4498](#4498)) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
providerConfigstate property is being removed from NetworkController. Currently this property is used in GasFeeController to get the currently selected chain, butselectedNetworkClientIdcan be used instead. This commit makes that transition so that we can fully dropproviderConfig.References
Progresses #4185.
Changelog
(There should be no functional changes, so no changelog updates are needed.)
Checklist