-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransactionController: providerConfig -> selectedNetworkClientId #4357
Merged
mcmire
merged 8 commits into
main
from
remove-provider-config-from-transaction-controller
Jun 7, 2024
Merged
TransactionController: providerConfig -> selectedNetworkClientId #4357
mcmire
merged 8 commits into
main
from
remove-provider-config-from-transaction-controller
Jun 7, 2024
Commits on May 31, 2024
-
TransactionController: providerConfig -> selectedNetworkClientId
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`.
Configuration menu - View commit details
-
Copy full SHA for 484a76a - Browse repository at this point
Copy the full SHA 484a76aView commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1694f1d - Browse repository at this point
Copy the full SHA 1694f1dView commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 740e311 - Browse repository at this point
Copy the full SHA 740e311View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fbc28b - Browse repository at this point
Copy the full SHA 0fbc28bView commit details
Commits on Jun 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for af7bdc2 - Browse repository at this point
Copy the full SHA af7bdc2View commit details -
Update packages/transaction-controller/src/TransactionController.test.ts
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for e5196f7 - Browse repository at this point
Copy the full SHA e5196f7View commit details -
Update packages/transaction-controller/src/TransactionController.test.ts
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Configuration menu - View commit details
-
Copy full SHA for 1c93514 - Browse repository at this point
Copy the full SHA 1c93514View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75c7e9a - Browse repository at this point
Copy the full SHA 75c7e9aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.