-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transaction-controller): Return global ethQuery when !isMultichainEnabled
#4390
fix(transaction-controller): Return global ethQuery when !isMultichainEnabled
#4390
Conversation
!isMultichainEnabled
5a05293
to
31b2ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
31b2ea0
to
a365586
Compare
(Conflict resolution) |
a365586
to
5a311c5
Compare
The existing test is here. See also the |
48bcfb6
to
3f23743
Compare
The test-related changes have now been separated into #4391. This PR now contains the fix in isolation. |
…eturn ethQuery for global provider when !isMultichainEnabled
3f23743
to
bb80e40
Compare
Explanation
There is a test stating that "
MultichainTrackingHelper.getEthQuery
should always returnethQuery
for global provider when !isMultichainEnabled`".It was not, but the test was passing anyway due to the mock being hardcoded to do so. This fixes that.
Also refactors tests to actually test for it(separately in #4391).(Aside: I'm not sure why there even is a distinction between "global provider" and "chain-specific providers" in the first place - seems like there should never be a reason for both to exist simultaneously?)Answer: This is transitory and the "global provider" us due to be refactored away.References
Related
Blocking
Changelog
@metamask/transaction-controller
MultichainTrackingHelper.getEthQuery
now returns globalethQuery
withChecklist