-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove global network from signature controller #4797
feat: remove global network from signature controller #4797
Conversation
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
2c5a4f9
to
6d497e3
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Explanation
Remove all global network usage from the signature controller to support multi-chain in the clients.
Specifically:
getCurrentChainId
constructor callback fromSignatureController
.chainId
usingnetworkClientId
fromrequest
argument andNetworkController
messenger action.chainId
andnetworkClientId
in state.References
Fixes #3498
Extension Adoption
Mobile Adoption
Changelog
@metamask/signature-controller
request
argument required innewUnsignedPersonalMessage
andnewUnsignedTypedMessage
methods.chainId
andnetworkClientId
toSignatureRequest
andLegacyMessage
types.networkClientId
provided or ifchainId
cannot be determined.getCurrentChainId
andgetAllState
callbacks from constructor options.Checklist