Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eth-sig-util dependency to 8.0.0 for signature-controller #4830

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

OGPoyraz
Copy link
Member

Explanation

This PR updates eth-sig-util dependency for signature-controller. Recent change in package remove the normalization for numerical addresses.

References

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3298

Changelog

@metamask/signature-controller

  • CHANGED: Bump eth-sig-util dependency to 8.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@OGPoyraz OGPoyraz requested review from a team as code owners October 22, 2024 09:27
Copy link

socket-security bot commented Oct 22, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-sig-util@8.0.0 None +7 206 kB metamaskbot

View full report↗︎

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as breaking since we are restricting the type of parameters accepted? Based on the package changelog numeric values will break

@OGPoyraz
Copy link
Member Author

Good call @mikesposito , I think the changelog in the eth-sig-util is a bit misleading, we actually lift off a validation so it is actually a change but not breaking in this case.

@OGPoyraz OGPoyraz merged commit 6f5f6e1 into main Oct 22, 2024
119 checks passed
@OGPoyraz OGPoyraz deleted the 3298-permit-bypass-numerical-address-for-owner-field branch October 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants