Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @metamask/utils #4831

Merged
merged 4 commits into from
Oct 24, 2024
Merged

chore: Bump @metamask/utils #4831

merged 4 commits into from
Oct 24, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 22, 2024

Explanation

Bump metamask/utils to 10.0.0 and metamask/rpc-errors to 7.0.1 in an attempt to unblock usage of latest utils in snaps.

Changelog

Omitted.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@FrederikBolding FrederikBolding force-pushed the fb/major-bump-utils branch 2 times, most recently from 67ea11d to 54aae63 Compare October 22, 2024 11:01
Copy link

socket-security bot commented Oct 24, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/rpc-errors@7.0.0

View full report↗︎

@FrederikBolding FrederikBolding marked this pull request as ready for review October 24, 2024 10:26
@FrederikBolding FrederikBolding requested review from a team as code owners October 24, 2024 10:26
@legobeat legobeat changed the title chore: Bump utils chore: Bump @metamask/utils Oct 24, 2024
@FrederikBolding FrederikBolding changed the title chore: Bump @metamask/utils chore: Bump @metamask/utils Oct 24, 2024
@@ -3764,6 +3764,23 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/utils@npm:^10.0.0":
Copy link
Contributor

@legobeat legobeat Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8 and v9 are still in use by transitive snaps packages, but I guess that's intended to resolve in a follow-up.

Related:

Copy link
Member Author

@FrederikBolding FrederikBolding Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this strictly is meant to unblock usage of the latest utils version in Snaps, since we want a performance improvement that is included in the latest version.

Copy link
Contributor

@legobeat legobeat Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider holding back update in @metamask/accounts-controller to keep the versions consistent withing packages? There's a configuration for bypassing the resulting failing constraint in yarn.config.cjs.

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and smooth!

@FrederikBolding FrederikBolding merged commit 35b900b into main Oct 24, 2024
119 checks passed
@FrederikBolding FrederikBolding deleted the fb/major-bump-utils branch October 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants