From c970faff01eae893bc32ae7c7a513fbb31495182 Mon Sep 17 00:00:00 2001
From: tommasini <tommasini15@gmail.com>
Date: Tue, 22 Oct 2024 22:48:46 +0100
Subject: [PATCH] Unnecessary state update when the balance did not change at
 account tracker controller polling mechanism, which was causing unnecessary
 re renders

---
 .../src/AccountTrackerController.ts           | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/packages/assets-controllers/src/AccountTrackerController.ts b/packages/assets-controllers/src/AccountTrackerController.ts
index fb1f131cc7..15bc14ccd9 100644
--- a/packages/assets-controllers/src/AccountTrackerController.ts
+++ b/packages/assets-controllers/src/AccountTrackerController.ts
@@ -343,21 +343,24 @@ export class AccountTrackerController extends StaticIntervalPollingController<
         : [toChecksumHexAddress(selectedAccount.address)];
 
       const accountsForChain = { ...accountsByChainId[chainId] };
+      let balanceChanged = false;
       for (const address of accountsToUpdate) {
         const balance = await this.#getBalanceFromChain(address, ethQuery);
-        if (balance) {
+        if (balance && accountsForChain[address]?.balance !== balance) {
           accountsForChain[address] = {
             balance,
           };
+          balanceChanged = true;
         }
       }
-
-      this.update((state) => {
-        if (chainId === this.#getCurrentChainId()) {
-          state.accounts = accountsForChain;
-        }
-        state.accountsByChainId[chainId] = accountsForChain;
-      });
+      if (balanceChanged) {
+        this.update((state) => {
+          if (chainId === this.#getCurrentChainId()) {
+            state.accounts = accountsForChain;
+          }
+          state.accountsByChainId[chainId] = accountsForChain;
+        });
+      }
     } finally {
       releaseLock();
     }