Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove addNewAccountWithoutUpdate #4845

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: remove addNewAccountWithoutUpdate #4845

wants to merge 3 commits into from
+6 −47

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Oct 24, 2024 •
edited
Loading

Explanation

As updating identities in clients isn't a KeyringController responsibility anymore, the addNewAccountWithoutUpdate has no reason to exist here.

This method is currently used in one place, and there is an open PR to remove it.

References

Changelog

@metamask/keyring-controller

  • BREAKING: Remove addNewAccountWithoutUpdate

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito marked this pull request as ready for review October 24, 2024 12:35
@mikesposito mikesposito requested review from a team as code owners October 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikesposito