Fix ESLint config #5132
Open
Fix ESLint config #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to ESLint 9 which occurred in a previous commit was not done correctly. An array must be passed to `createConfig` instead of a series of arguments. As a result, a lot of lint rules were accidentally disabled. This commit fixes the ESLint config and corrects any lint violations. It turns out that upgrading the ESLint packages created a bunch of new lint violations, so those have been turned into warnings rather than errors. To prevent new instances of these violations from occurring, a script has been added which captures existing warning counts and exits with a non-zero exit code if the count increases. This script is also now used for `yarn lint:eslint` so that CI will fail if the count increases.
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The upgrade to ESLint 9 which occurred in a previous commit was not done correctly. An array must be passed to
createConfiginstead of a series of arguments. As a result, a lot of lint rules were accidentally disabled.This commit fixes the ESLint config and corrects any lint violations. It turns out that upgrading the ESLint packages created a bunch of new lint violations, so those have been turned into warnings rather than errors. To prevent new instances of these violations from occurring, a script has been added which captures existing warning counts and exits with a non-zero exit code if the count increases. This script is also now used for
yarn lint:eslintso that CI will fail if the count increases.References
Changelog
N/A (developer change only)
Checklist