-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update CSS variables with new tokens #691
Conversation
- black000 renamed to black | ||
|
||
### Brand Colors Brand Evolution | ||
- Blue updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These brand colors brand evolution updates are compared against the updated brand colors
--brand-colors-blue-blue600: #0260a4; | ||
--brand-colors-blue-blue700: #024272; | ||
--brand-colors-blue-blue800: #01253f; | ||
--brand-colors-blue-blue900: #00080d; | ||
/* Orange */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reordered to match with json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Grey updates | ||
- grey000 added | ||
- grey025 added | ||
- grey050 added | ||
- grey030 removed | ||
- grey040 removed | ||
- grey750 removed | ||
- grey1000 added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the final migration documentation, it would be beneficial to include specific code changes. Added
JS
Added
brandColor.grey000
brandColor.grey025
Removed
brandColor.grey030
CSS
Added
--brand-colors-grey-grey000
--brand-colors-grey-grey025
Removed
--brand-colors-grey-grey030
This detail will aid engineers who are searching for removed tokens in the codebase. cc @garrettbear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want me to update this to reflect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tho the colors will be the same for both changes, the difference is syntax. curious if theres a better way to list this instead of duplicating it
* feat: updated css color variables * feat: updated migration doc with token changes * fix: updated comments in css variables * refactor: updated spacing * feat: added descriptions as comments to themed tokens * fix: removed newline * fix: updated css format * fix: updated lime800 color * fix: removed root from dark colors * adding line breaks in migration doc --------- Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Description
This PR
Related issues
Fixes: #687
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist