feat: Update CSS variables with new tokens #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianacnguyen
added
color
brianacnguyen
commented
May 22, 2024
| - black000 renamed to black | ||
|
|
||
| ### Brand Colors Brand Evolution | ||
| - Blue updates |
There was a problem hiding this comment.
These brand colors brand evolution updates are compared against the updated brand colors
brianacnguyen
commented
May 22, 2024
| --brand-colors-blue-blue600: #0260a4; | ||
| --brand-colors-blue-blue700: #024272; | ||
| --brand-colors-blue-blue800: #01253f; | ||
| --brand-colors-blue-blue900: #00080d; | ||
| /* Orange */ |
There was a problem hiding this comment.
reordered to match with json file
Comment on lines
+37
to
+44
| - Grey updates | ||
| - grey000 added | ||
| - grey025 added | ||
| - grey050 added | ||
| - grey030 removed | ||
| - grey040 removed | ||
| - grey750 removed | ||
| - grey1000 added |
There was a problem hiding this comment.
In the final migration documentation, it would be beneficial to include specific code changes. Added
JS
Added
brandColor.grey000
brandColor.grey025
Removed
brandColor.grey030
CSS
Added
--brand-colors-grey-grey000
--brand-colors-grey-grey025
Removed
--brand-colors-grey-grey030
This detail will aid engineers who are searching for removed tokens in the codebase. cc @garrettbear
There was a problem hiding this comment.
do you want me to update this to reflect that?
There was a problem hiding this comment.
tho the colors will be the same for both changes, the difference is syntax. curious if theres a better way to list this instead of duplicating it
georgewrmarshall
approved these changes
May 22, 2024
georgewrmarshall
added a commit
that referenced
this pull request
May 22, 2024
* feat: updated css color variables * feat: updated migration doc with token changes * fix: updated comments in css variables * refactor: updated spacing * feat: added descriptions as comments to themed tokens * fix: removed newline * fix: updated css format * fix: updated lime800 color * fix: removed root from dark colors * adding line breaks in migration doc --------- Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Related issues
Fixes: #687
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist