-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating doc components and helpers #706
Conversation
docs/BrandColors.stories.tsx
Outdated
@@ -22,6 +26,7 @@ type Story = StoryObj<typeof ColorSwatchGroup>; | |||
export const Figma: Story = { | |||
render: () => { | |||
const { brandColor } = useJsonColor(); | |||
console.log(brandColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's retain console logs in the stories while we are working on these updates I find it's quite helpful. Maybe we can change the console logs to
console.log(brandColor); | |
console.log('brandColor JSON', brandColor); |
a6865ed
to
f7496ef
Compare
@@ -22,6 +26,7 @@ type Story = StoryObj<typeof ColorSwatchGroup>; | |||
export const Figma: Story = { | |||
render: () => { | |||
const { brandColor } = useJsonColor(); | |||
console.log('brandColor JSON', brandColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to retain console logs until we finish the brand evolution work it's quite hepful
if (theme[category]?.[key]) { | ||
resolvedValue = parseColorValue( | ||
theme[category][key].value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/figma/brandColors.json
Outdated
}, | ||
"white": { | ||
"value": "#ffffff", | ||
"type": "color", | ||
"parent": "Brand Colors/v1 - current", | ||
"description": "" | ||
}, | ||
"black": { | ||
"value": "#000000", | ||
"type": "color", | ||
"parent": "Brand Colors/v1 - current", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding white and black tokens here to test the updates to useJsonColor
hook
@@ -1,5 +1,6 @@ | |||
import React, { FunctionComponent } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Includes all the changes from #698. I think it would be good to get these into main so we can separate documentation UI updates from actual token color changes.
f7496ef
to
50b6468
Compare
Description
This PR updates Storybook documentation components and helpers. No tokens are affected in this update; only the documentation components and helpers have been modified. The purpose of these changes is to separate non-breaking changes from PR #698 for easier review and to facilitate the comparison of token changes.
ColorSwatch
s to use black/white text dependent on toneRelated issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
before720.mov
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist