New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for Node.js versions 16, 21 #109

Merged

legobeat merged 2 commits into MetaMask:main from legobeat:node-18

Oct 14, 2024

Contributor

legobeat commented Oct 3, 2024 •

edited

Loading

Drop support for Node.js versions 16, 21
Add Node.js v22 to CI matrix
ci: yarn --ignore-engines to work around out of date eslint-plugin-jsdoc

Related

Synchronize with module template (Feb 2024) #104

Blocking

legobeat force-pushed the node-18 branch from 73e0f4f to 72c3b51 Compare

October 3, 2024 00:46

socket-security bot commented Oct 3, 2024 •

edited

Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/generator@7.23.0	None	`0`	487 kB	nicolo-ribaudo
npm/@babel/parser@7.23.0	None	`0`	1.89 MB	nicolo-ribaudo
npm/@types/node@18.19.54	None	`0`	2.02 MB	types
npm/undici-types@5.26.5	None	`0`	73.1 kB	ethan_arrowood

🚮 Removed packages: npm/@babel/generator@7.22.15, npm/@babel/parser@7.22.16, npm/@types/node@16.18.46

View full report↗︎

legobeat added 2 commits

October 3, 2024 00:57


          drop support for Node.js versions 16, 21

140811e


          ci: yarn --ignore-engines

fc19383

Resolves:

 error eslint-plugin-jsdoc@43.0.7: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19 || ^20". Got "22.9.0"

ignore-engines is default behavior in newer yarn versions.

legobeat force-pushed the node-18 branch from 603d9c5 to fc19383 Compare

October 3, 2024 00:57

legobeat mentioned this pull request

fix(deps): drop node-fetch #110

Merged

1 task

legobeat marked this pull request as ready for review

October 3, 2024 00:58

legobeat requested a review from a team as a code owner

October 3, 2024 00:58

This was referenced Oct 3, 2024

Synchronize with module template (Feb 2024) #104

Open

drop support for Node.js versions 16, 21 MetaMask/utils#212

Merged

legobeat added team-wallet-framework team-accounts labels

legobeat mentioned this pull request

deps: @metamask/rpc-errors@^6.0.0->^7.0.0 #111

Merged

cryptodev-2s approved these changes

View reviewed changes

legobeat merged commit 08c725b into MetaMask:main

8 checks passed

legobeat deleted the node-18 branch

October 14, 2024 20:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-accounts team-wallet-framework