Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: replace deep-cloning implementation clone with klona #250

Merged
merged 4 commits into from
Sep 25, 2023
Merged

deps: replace deep-cloning implementation clone with klona #250

merged 4 commits into from
Sep 25, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 21, 2023 •
edited
Loading

Blocking

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 21, 2023
This was referenced Sep 21, 2023
Merged
Closed
@legobeat legobeat marked this pull request as ready for review September 21, 2023 22:07
@legobeat legobeat requested a review from a team as a code owner September 21, 2023 22:07
@legobeat legobeat requested review from a team September 21, 2023 22:07
@legobeat legobeat mentioned this pull request Sep 21, 2023
Merged
14 tasks
@socket-security
Copy link

socket-security bot commented Sep 25, 2023 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/pify 3.0.2...5.0.2 None +0/-0 5.1 kB types

🚮 Removed packages: @types/clone@2.1.1, pify@3.0.0

mikesposito
mikesposito previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikesposito
mikesposito previously approved these changes Sep 25, 2023
View reviewed changes
@legobeat
Copy link
Contributor Author

@mikesposito Thanks for review :) Original PR did not actually remove clone as a dependency. This has now been done here.

@mikesposito
Copy link
Member

@legobeat Good catch because I didn't notice 😄

@legobeat legobeat merged commit 0968bf0 into MetaMask:main Sep 25, 2023
16 checks passed
@jimmywarting
Copy link

when dropping support for NodeJS v16 and below, then you can maybe native structuredClone?

@legobeat legobeat deleted the deps-replace-clone branch September 26, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesposito mikesposito mikesposito approved these changes

@jiexi jiexi Awaiting requested review from jiexi

@danroc danroc Awaiting requested review from danroc

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mikesposito @jimmywarting