fix: change types signatures verifyingContract validation to allow 'cosmos' as address #334
Conversation
jpuri
changed the title
| // https://github.com/MetaMask/metamask-extension/issues/26980 | ||
| if ( | ||
| verifyingContract && | ||
| (verifyingContract as string) !== 'cosmos' && |
There was a problem hiding this comment.
We're going to introduce this single exception? Doesn't it seem possible there are other cases here that we're going to be chasing? Do we have a plan to deprecate support for this exception and start enforcing this more strictly or?
cc @MetaMask/wallet-api-platform-engineers
There was a problem hiding this comment.
Cosmos network DAPPs are using this deprecated SDK which has verifyingContract hard coded to cosmos https://github.com/evmos/ethermint/blob/main/ethereum/eip712/domain.go#L29 thus we need to do it to support cosmos network. Once this old library goes out of use we can revert the change.
We do not see more such cases currently.
There was a problem hiding this comment.
if I understand correctly we are planning on removing this sometime in the future: if so, to make sure we don't lose track of it, perhaps we can open a new issue and mention it in the code comment instead of using the issue that will be closed by this PR (#26980)?
There was a problem hiding this comment.
Good point @mikesposito , I added this issue #337 and updated the comment.
* origin/main: fix: change types signatures verifyingContract validation to allow 'cosmos' as address (#334) Update `main` with changes from v14.0.1 (#332) Request validation should not throw if verifyingContract is not defined in typed signature (#328) Add changelog entries for `#318` (#327) remove eth_sign (#320)
Fixes: MetaMask/metamask-extension#27070
Following the discussion in the thread, I am moving this validation to middleware. https://consensys.slack.com/archives/C02GENU377A/p1725914308614879
Original issue which got a hotfix: MetaMask/metamask-extension#26980