Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for Node.js versions 16, 21 #390

Merged
merged 2 commits into from
Oct 14, 2024
Merged

drop support for Node.js versions 16, 21 #390

merged 2 commits into from
Oct 14, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2024 •
edited
Loading

  • Remove support for EoL Node.js versions 16, 21
  • Align version of @types/node
  • ci: Only run lint on default Node version
    • ci: Bump @actions/setup-node to v4
    • ci: Simplify caching of yarn node modules
  • ci: Run on Node.js v22

Related

Blocking

@socket-security Socket Security
Copy link

socket-security bot commented Oct 3, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@18.18.14 None 0 3.8 MB types
npm/undici-types@5.26.5 None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@types/node@16.18.50

View full report↗︎

This was referenced Oct 3, 2024
Merged
Open
Open
Merged
@ccharly

This comment was marked as resolved.

Sign in to view
@legobeat legobeat marked this pull request as ready for review October 7, 2024 11:01
@legobeat legobeat requested review from ccharly and a team October 7, 2024 11:02
@legobeat
Copy link
Contributor Author

legobeat commented Oct 9, 2024

@ccharly Updated accordingly! 👍

@legobeat legobeat merged commit bce4f64 into MetaMask:main Oct 14, 2024
16 checks passed
@legobeat legobeat mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@ccharly ccharly Awaiting requested review from ccharly

Assignees
No one assigned
Labels
team-accounts team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @ccharly @cryptodev-2s