This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: add new optional field in InternalAccount metadata
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: Drafting this PR for now since there's a chance we might not need this feature ATM.
This PR adds a new optional field for
InternalAccountmetadata,conflictingNames.This field will be crucial in the implementation of the new Account syncing feature (from @MetaMask/notifications ).
It will be used to temporarily store conflicting account names in the client after a successful account sync but with name conflicts. This metadata field will then be cleared when a user choses the correct account name from the UI.
Related to this Epic
Examples
This will be used by the
AccountsControllerto get the correctInternalAccounttype and get/set the newconflictingNamesfield when needed.Ref: https://github.com/MetaMask/core/tree/main/packages/accounts-controller