Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Flask 12.4 #1540

Merged
merged 19 commits into from
Sep 26, 2024
Merged

Update docs for Flask 12.4 #1540

merged 19 commits into from
Sep 26, 2024
+710 −1,099

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Sep 9, 2024 •
edited
Loading

  • Document Checkbox component
  • Document Snaps Icon component
  • Update onHomePage screenshot
  • Document Snaps Tooltip component
  • Document Snaps RadioGroup component
  • Document Selector component
  • Document color and alignment props of Text
  • Document context in snap_createInterface and onUserInput
  • Document FileInput component

Closes #1522.

@ziad-saab ziad-saab requested review from a team as code owners September 9, 2024 16:06
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:46am

@ziad-saab ziad-saab marked this pull request as draft September 9, 2024 16:06
@ziad-saab ziad-saab added tech-writing Requires updates to documentation content. snaps Related to Snaps content. labels Sep 10, 2024
@ziad-saab ziad-saab changed the title WIP - Update docs for Flask 12.4 Update docs for Flask 12.4 Sep 24, 2024
@ziad-saab ziad-saab marked this pull request as ready for review September 24, 2024 17:00
@alexandratran alexandratran self-assigned this Sep 25, 2024
alexandratran
alexandratran previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor format/style edits. A few outstanding questions. Also, should any of the added components have the Flask admonition attached?

snaps/features/custom-ui/with-jsx.md Outdated Show resolved Hide resolved
snaps/features/custom-ui/with-jsx.md Outdated Show resolved Hide resolved
snaps/features/custom-ui/with-jsx.md Outdated Show resolved Hide resolved
@alexandratran
Copy link
Contributor

@Montoya

Also after this is merged I think this page content: https://docs.metamask.io/snaps/features/custom-ui/

Should just be entirely replaced with this page: https://metamask-docs-3x444rekv-metamask-web.vercel.app/snaps/features/custom-ui/

And then we can remove all the code examples using the old UI library.

Do you want to just replace the old page in this same PR?

@Montoya
Copy link
Collaborator

Montoya commented Sep 25, 2024

@alexandratran I would be OK with that

@alexandratran alexandratran requested a review from a team as a code owner September 26, 2024 01:55
alexandratran
alexandratran previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the old custom UI index page with the JSX one. Other minor edits and fixes. LGTM.

Montoya
Montoya previously approved these changes Sep 26, 2024
View reviewed changes
@Montoya Montoya dismissed stale reviews from alexandratran and themself via ddfa0b7 September 26, 2024 03:36
@Montoya
Copy link
Collaborator

Montoya commented Sep 26, 2024

Found more things to fix @alexandratran , will need re-review :)

@Montoya Montoya merged commit 6f3df56 into main Sep 26, 2024
9 checks passed
@Montoya Montoya deleted the zs/snaps-12.4 branch September 26, 2024 03:52
@Montoya
Copy link
Collaborator

Montoya commented Sep 26, 2024

Great work @ziad-saab @alexandratran 🥂

@alexandratran alexandratran mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@Montoya Montoya Montoya approved these changes

Assignees

@alexandratran alexandratran

Labels
snaps Related to Snaps content. tech-writing Requires updates to documentation content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Snaps documentation for v12.4
3 participants
@ziad-saab @Montoya @alexandratran