Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: bump
@metamask/eth-snap-keyring
to version 4.4.0 (#27864)
## **Description** Bumping the Snap bridge. This new version will now sanitize the redirect URL passed by a Snap. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27864?quickstart=1) ## **Related issues** Fixes: MetaMask/accounts-planning#585 ## **Manual testing steps** 1. `yarn start:flask` 2. Use the SSK Snap with the following branch: `test/keyring-snap-bridge-70` 3. Run the SSK dapp + Snap using `yarn start`, go to http://localhost:8000/ 4. Install the Snap 5. Make sure that "Use Synchronous Approval" on the SSK dapp is **disabled** 6. Create an SSK account 7. Go to https://metamask.github.io/test-dapp/ 8. Connect your SSK account 9. Use the personal sign test 10. You should see a sanitized URL `https://ioi.com?fake=1` on the Snap dialog ## **Screenshots/Recordings** ### **Before** ![Screenshot 2024-10-11 at 11 19 52](https://github.com/user-attachments/assets/60661c21-18cd-4570-b642-a47650258556) ### **After** ![Screenshot 2024-10-11 at 12 22 59](https://github.com/user-attachments/assets/819d3ef5-2b09-4b43-8118-0870ee695bff) ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
- Loading branch information