Skip to content

Commit

Permalink
chore: bump @metamask/eth-snap-keyring to version 4.4.0 (#27864)
Browse files Browse the repository at this point in the history
## **Description**

Bumping the Snap bridge. This new version will now sanitize the redirect
URL passed by a Snap.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27864?quickstart=1)

## **Related issues**

Fixes: MetaMask/accounts-planning#585

## **Manual testing steps**

1. `yarn start:flask`
2. Use the SSK Snap with the following branch:
`test/keyring-snap-bridge-70`
3. Run the SSK dapp + Snap using `yarn start`, go to
http://localhost:8000/
4. Install the Snap
5. Make sure that "Use Synchronous Approval" on the SSK dapp is
**disabled**
6. Create an SSK account
7. Go to https://metamask.github.io/test-dapp/
8. Connect your SSK account
9. Use the personal sign test
10. You should see a sanitized URL `https://ioi.com?fake=1` on the Snap
dialog

## **Screenshots/Recordings**

### **Before**

![Screenshot 2024-10-11 at 11 19
52](https://github.com/user-attachments/assets/60661c21-18cd-4570-b642-a47650258556)

### **After**

![Screenshot 2024-10-11 at 12 22
59](https://github.com/user-attachments/assets/819d3ef5-2b09-4b43-8118-0870ee695bff)


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
  • Loading branch information
ccharly and metamaskbot authored Oct 17, 2024
1 parent bbba7c5 commit 043ea3f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@
"@metamask/eth-ledger-bridge-keyring": "^3.0.1",
"@metamask/eth-query": "^4.0.0",
"@metamask/eth-sig-util": "^7.0.1",
"@metamask/eth-snap-keyring": "^4.3.6",
"@metamask/eth-snap-keyring": "^4.4.0",
"@metamask/eth-token-tracker": "^8.0.0",
"@metamask/eth-trezor-keyring": "^3.1.3",
"@metamask/etherscan-link": "^3.0.0",
Expand Down
22 changes: 11 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5382,22 +5382,22 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eth-snap-keyring@npm:^4.3.1, @metamask/eth-snap-keyring@npm:^4.3.6":
version: 4.3.6
resolution: "@metamask/eth-snap-keyring@npm:4.3.6"
"@metamask/eth-snap-keyring@npm:^4.3.1, @metamask/eth-snap-keyring@npm:^4.3.6, @metamask/eth-snap-keyring@npm:^4.4.0":
version: 4.4.0
resolution: "@metamask/eth-snap-keyring@npm:4.4.0"
dependencies:
"@ethereumjs/tx": "npm:^4.2.0"
"@metamask/eth-sig-util": "npm:^7.0.3"
"@metamask/snaps-controllers": "npm:^9.7.0"
"@metamask/snaps-sdk": "npm:^6.5.1"
"@metamask/snaps-utils": "npm:^7.8.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
"@metamask/superstruct": "npm:^3.1.0"
"@metamask/utils": "npm:^9.2.1"
"@types/uuid": "npm:^9.0.8"
uuid: "npm:^9.0.1"
peerDependencies:
"@metamask/keyring-api": ^8.1.3
checksum: 10/378dce125ba9e38b9ba7d9b7124383b4fd8d2782207dc69e1ae9e262beb83f22044eae5200986d4c353de29e5283c289e56b3acb88c8971a63f9365bdde3d5b4
checksum: 10/fd9926ba3706506bd9a16d1c2501e7c6cd7b7e3e7ea332bc7f28e0fca1f67f4514da51e6f9f4541a7354a2363d04c09c445f61b98fdc366432e1def9c2f27d07
languageName: node
linkType: hard

Expand Down Expand Up @@ -6282,7 +6282,7 @@ __metadata:
languageName: node
linkType: hard

"@metamask/snaps-controllers@npm:^9.11.1, @metamask/snaps-controllers@npm:^9.7.0":
"@metamask/snaps-controllers@npm:^9.10.0, @metamask/snaps-controllers@npm:^9.11.1":
version: 9.11.1
resolution: "@metamask/snaps-controllers@npm:9.11.1"
dependencies:
Expand Down Expand Up @@ -6379,7 +6379,7 @@ __metadata:
languageName: node
linkType: hard

"@metamask/snaps-utils@npm:^7.4.0, @metamask/snaps-utils@npm:^7.8.1":
"@metamask/snaps-utils@npm:^7.4.0":
version: 7.8.1
resolution: "@metamask/snaps-utils@npm:7.8.1"
dependencies:
Expand Down Expand Up @@ -6410,7 +6410,7 @@ __metadata:
languageName: node
linkType: hard

"@metamask/snaps-utils@npm:^8.1.1, @metamask/snaps-utils@npm:^8.4.0, @metamask/snaps-utils@npm:^8.4.1":
"@metamask/snaps-utils@npm:^8.1.1, @metamask/snaps-utils@npm:^8.3.0, @metamask/snaps-utils@npm:^8.4.0, @metamask/snaps-utils@npm:^8.4.1":
version: 8.4.1
resolution: "@metamask/snaps-utils@npm:8.4.1"
dependencies:
Expand Down Expand Up @@ -26134,7 +26134,7 @@ __metadata:
"@metamask/eth-ledger-bridge-keyring": "npm:^3.0.1"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/eth-sig-util": "npm:^7.0.1"
"@metamask/eth-snap-keyring": "npm:^4.3.6"
"@metamask/eth-snap-keyring": "npm:^4.4.0"
"@metamask/eth-token-tracker": "npm:^8.0.0"
"@metamask/eth-trezor-keyring": "npm:^3.1.3"
"@metamask/etherscan-link": "npm:^3.0.0"
Expand Down

0 comments on commit 043ea3f

Please sign in to comment.