remove the Sentry from this property as it's now implied by the par…

…ent property
MetaMask · Oct 1, 2024 · 0788633 · 0788633
1 parent 5639952
commit 0788633
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 23 deletions.
diff --git a/app/scripts/lib/manifestFlags.ts b/app/scripts/lib/manifestFlags.ts
@@ -11,7 +11,7 @@ export type ManifestFlags = {
   };
   sentry?: {
     tracesSampleRate?: number;
-    doNotForceSentryForThisTest?: boolean;
+    doNotForceForThisTest?: boolean;
   };
 };
 

diff --git a/app/scripts/lib/setupSentry.js b/app/scripts/lib/setupSentry.js
@@ -238,7 +238,7 @@ function getSentryEnvironment() {
 
 function getSentryTarget() {
   if (
-    getManifestFlags().sentry?.doNotForceSentryForThisTest ||
+    getManifestFlags().sentry?.doNotForceForThisTest ||
     (process.env.IN_TEST && !SENTRY_DSN_DEV)
   ) {
     return SENTRY_DSN_FAKE;
@@ -272,7 +272,7 @@ async function getMetaMetricsEnabled() {
 
   if (
     METAMASK_BUILD_TYPE === 'mmi' ||
-    (flags.circleci && !flags.sentry?.doNotForceSentryForThisTest)
+    (flags.circleci && !flags.sentry?.doNotForceForThisTest)
   ) {
     return true;
   }

diff --git a/test/e2e/tests/metrics/errors.spec.js b/test/e2e/tests/metrics/errors.spec.js
@@ -247,7 +247,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryMigratorError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -278,7 +278,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryTestError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -319,7 +319,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryMigratorError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -365,7 +365,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryMigratorError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -426,7 +426,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryInvariantMigrationError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -475,7 +475,7 @@ describe('Sentry errors', function () {
           testSpecificMock: mockSentryTestError,
           ignoredConsoleErrors: ['TestError'],
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -521,7 +521,7 @@ describe('Sentry errors', function () {
           testSpecificMock: mockSentryTestError,
           ignoredConsoleErrors: ['TestError'],
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -585,7 +585,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryTestError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -621,7 +621,7 @@ describe('Sentry errors', function () {
           testSpecificMock: mockSentryTestError,
           ignoredConsoleErrors: ['TestError'],
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -656,7 +656,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryTestError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -702,7 +702,7 @@ describe('Sentry errors', function () {
           title: this.test.fullTitle(),
           testSpecificMock: mockSentryTestError,
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, ganacheServer, mockedEndpoint }) => {
@@ -766,7 +766,7 @@ describe('Sentry errors', function () {
           testSpecificMock: mockSentryTestError,
           ignoredConsoleErrors: ['TestError'],
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, mockedEndpoint }) => {
@@ -810,7 +810,7 @@ describe('Sentry errors', function () {
           testSpecificMock: mockSentryTestError,
           ignoredConsoleErrors: ['TestError'],
           manifestFlags: {
-            sentry: { doNotForceSentryForThisTest: true },
+            sentry: { doNotForceForThisTest: true },
           },
         },
         async ({ driver, ganacheServer, mockedEndpoint }) => {
@@ -898,7 +898,7 @@ describe('Sentry errors', function () {
         ganacheOptions,
         title: this.test.fullTitle(),
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver }) => {

diff --git a/test/e2e/tests/metrics/sessions.spec.ts b/test/e2e/tests/metrics/sessions.spec.ts
@@ -38,7 +38,7 @@ describe('Sessions', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentrySession,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {
@@ -60,7 +60,7 @@ describe('Sessions', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentrySession,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {

diff --git a/test/e2e/tests/metrics/traces.spec.ts b/test/e2e/tests/metrics/traces.spec.ts
@@ -51,7 +51,7 @@ describe('Traces', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentryCustomTrace,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {
@@ -73,7 +73,7 @@ describe('Traces', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentryCustomTrace,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {
@@ -95,7 +95,7 @@ describe('Traces', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentryAutomatedTrace,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {
@@ -117,7 +117,7 @@ describe('Traces', function () {
         title: this.test?.fullTitle(),
         testSpecificMock: mockSentryAutomatedTrace,
         manifestFlags: {
-          sentry: { doNotForceSentryForThisTest: true },
+          sentry: { doNotForceForThisTest: true },
         },
       },
       async ({ driver, mockedEndpoint }) => {