diff --git a/ui/components/component-library/button-base/button-base.tsx b/ui/components/component-library/button-base/button-base.tsx index 8c1282a69111..c4098c5f02ed 100644 --- a/ui/components/component-library/button-base/button-base.tsx +++ b/ui/components/component-library/button-base/button-base.tsx @@ -19,9 +19,8 @@ import { } from './button-base.types'; export const ButtonBase: ButtonBaseComponent = React.forwardRef( - ( + ( { - as = 'button', block, children, className = '', @@ -43,20 +42,16 @@ export const ButtonBase: ButtonBaseComponent = React.forwardRef( }: ButtonBaseProps, ref?: PolymorphicRef, ) => { - const Tag = href ? 'a' : as; - if (Tag === 'a' && externalLink) { - props.target = '_blank'; - props.rel = 'noopener noreferrer'; - } - return ( = PolymorphicComponentPropWithRef; -export type ButtonBaseComponent = ( +export type ButtonBaseComponent = < + C extends React.ElementType = 'button' | 'a', +>( props: ButtonBaseProps, ) => React.ReactElement | null;