From 18502f93bfa1df372a7ff6753410a34f292247f7 Mon Sep 17 00:00:00 2001
From: Howard Braham <howrad@gmail.com>
Date: Tue, 1 Oct 2024 18:17:49 -0700
Subject: [PATCH] Apply suggestions from legobbeat code review

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
---
 .circleci/scripts/git-diff-develop.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.circleci/scripts/git-diff-develop.ts b/.circleci/scripts/git-diff-develop.ts
index dee433b8fcdb..dafa12cc8eb5 100644
--- a/.circleci/scripts/git-diff-develop.ts
+++ b/.circleci/scripts/git-diff-develop.ts
@@ -47,9 +47,9 @@ async function getPrInfo(): Promise<PRInfo | null> {
  */
 async function fetchWithDepth(depth: number): Promise<boolean> {
   try {
-    await exec(`git fetch --depth ${depth} origin ${MAIN_BRANCH}`);
+    await exec(`git fetch --depth ${depth} origin "${MAIN_BRANCH}"`);
     await exec(
-      `git fetch --depth ${depth} origin ${SOURCE_BRANCH}:${SOURCE_BRANCH}`,
+      `git fetch --depth ${depth} origin "${SOURCE_BRANCH}:${SOURCE_BRANCH}"`,
     );
     return true;
   } catch (error: unknown) {
@@ -87,7 +87,7 @@ async function fetchUntilMergeBaseFound() {
       }
     }
   }
-  await exec(`git fetch --unshallow origin ${MAIN_BRANCH}`);
+  await exec(`git fetch --unshallow origin "${MAIN_BRANCH}"`);
 }
 
 /**
@@ -100,7 +100,7 @@ async function fetchUntilMergeBaseFound() {
 async function gitDiff(): Promise<string> {
   await fetchUntilMergeBaseFound();
   const { stdout: diffResult } = await exec(
-    `git diff --name-only origin/HEAD...${SOURCE_BRANCH}`,
+    `git diff --name-only "origin/HEAD...${SOURCE_BRANCH}"`,
   );
   if (!diffResult) {
     throw new Error('Unable to get diff after full checkout.');