-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adding / deleting additional RPC URLs (#25452)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Initial UI for adding and deleting multiple RPC URLs. The add and delete buttons don't do anything yet. Just UI until the network controller gets upgraded. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25452?quickstart=1) ## **Related issues** ## **Manual testing steps** 1. Build with ENABLE_NETWORK_UI_REDESIGN=1 yarn start 2. Open networks, right click edit one 3. Click RPC dropdown 4. Add and delete RPC endpoints ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/MetaMask/metamask-extension/assets/3500406/42047230-b258-4c1b-a37e-fb3c0f300913 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: David Walsh <davidwalsh83@gmail.com> Co-authored-by: salimtb <salim.toubal@outlook.com>
- Loading branch information
1 parent
fdc898e
commit 1f74b08
Showing
17 changed files
with
294 additions
and
59 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
72 changes: 72 additions & 0 deletions
72
ui/components/app/modals/confirm-delete-rpc-url-modal/confirm-delete-rpc-url-modal.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import React from 'react'; | ||
import { useDispatch } from 'react-redux'; | ||
import { | ||
BlockSize, | ||
Display, | ||
} from '../../../../helpers/constants/design-system'; | ||
import { | ||
Box, | ||
ButtonPrimary, | ||
ButtonPrimarySize, | ||
ButtonSecondary, | ||
ButtonSecondarySize, | ||
Modal, | ||
ModalBody, | ||
ModalContent, | ||
ModalHeader, | ||
ModalOverlay, | ||
} from '../../../component-library'; | ||
import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
import { | ||
hideModal, | ||
setEditedNetwork, | ||
toggleNetworkMenu, | ||
} from '../../../../store/actions'; | ||
|
||
const ConfirmDeleteRpcUrlModal = () => { | ||
const t = useI18nContext(); | ||
const dispatch = useDispatch(); | ||
return ( | ||
<Modal | ||
isClosedOnEscapeKey={true} | ||
isClosedOnOutsideClick={true} | ||
isOpen={true} | ||
onClose={() => { | ||
dispatch(setEditedNetwork()); | ||
dispatch(hideModal()); | ||
}} | ||
> | ||
<ModalOverlay /> | ||
<ModalContent> | ||
<ModalHeader>{t('confirmDeletion')}</ModalHeader> | ||
<ModalBody> | ||
<Box>{t('confirmRpcUrlDeletionMessage')}</Box> | ||
<Box display={Display.Flex} gap={4} marginTop={6}> | ||
<ButtonSecondary | ||
width={BlockSize.Full} | ||
size={ButtonSecondarySize.Lg} | ||
onClick={() => { | ||
dispatch(hideModal()); | ||
dispatch(toggleNetworkMenu()); | ||
}} | ||
> | ||
{t('back')} | ||
</ButtonSecondary> | ||
<ButtonPrimary | ||
width={BlockSize.Full} | ||
size={ButtonPrimarySize.Lg} | ||
danger={true} | ||
onClick={() => { | ||
console.log('TODO: Delete RPc URL'); | ||
}} | ||
> | ||
{t('deleteRpcUrl')} | ||
</ButtonPrimary> | ||
</Box> | ||
</ModalBody> | ||
</ModalContent> | ||
</Modal> | ||
); | ||
}; | ||
|
||
export default ConfirmDeleteRpcUrlModal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
ui/components/multichain/network-list-menu/add-rpc-url-modal/add-rpc-url-modal.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import React from 'react'; | ||
import { | ||
Box, | ||
ButtonPrimary, | ||
ButtonPrimarySize, | ||
FormTextField, | ||
} from '../../../component-library'; | ||
import { | ||
BlockSize, | ||
Display, | ||
TextVariant, | ||
} from '../../../../helpers/constants/design-system'; | ||
import { useI18nContext } from '../../../../hooks/useI18nContext'; | ||
|
||
const AddRpcUrlModal = () => { | ||
const t = useI18nContext(); | ||
|
||
return ( | ||
<Box padding={4}> | ||
<FormTextField | ||
id="additional-rpc-url" | ||
label={t('additionalRpcUrl')} | ||
labelProps={{ | ||
children: undefined, | ||
variant: TextVariant.bodySmMedium, | ||
}} | ||
/> | ||
|
||
<ButtonPrimary | ||
size={ButtonPrimarySize.Lg} | ||
display={Display.Block} | ||
width={BlockSize.Full} | ||
marginTop={8} | ||
marginLeft={'auto'} | ||
marginRight={'auto'} | ||
> | ||
{t('addUrl')} | ||
</ButtonPrimary> | ||
</Box> | ||
); | ||
}; | ||
|
||
export default AddRpcUrlModal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.