Skip to content

Commit

Permalink
feat: Display approve, increaseAllowance and revoke approval to users… (
Browse files Browse the repository at this point in the history
#26985)

… that opt-in


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This makes these redesigned screens available for users that opt into
redesigned transaction screens in the experimental settings page.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26985?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3246

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
pedronfigueiredo authored Sep 26, 2024
1 parent f36a831 commit 255fdae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ui/pages/confirmations/utils/confirm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ export const REDESIGN_APPROVAL_TYPES = [
export const REDESIGN_USER_TRANSACTION_TYPES = [
TransactionType.contractInteraction,
TransactionType.deployContract,
TransactionType.tokenMethodApprove,
TransactionType.tokenMethodIncreaseAllowance,
];

export const REDESIGN_DEV_TRANSACTION_TYPES = [
...REDESIGN_USER_TRANSACTION_TYPES,
TransactionType.tokenMethodApprove,
TransactionType.tokenMethodIncreaseAllowance,
TransactionType.tokenMethodSetApprovalForAll,
];

Expand Down

0 comments on commit 255fdae

Please sign in to comment.