Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: disable multiple send transactions (#25468)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Multiple transactions break STX logic; we need to prevent these transactions from being submitted concurrently. While the confirmations screen covers this, the swap+send flow bypasses this screen altogether, so we need to add logic to prevent submission via the instant submit button (i.e. submit for swap+send). <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25468?quickstart=1) ## **Related issues** Fixes: #25349 ## **Manual testing steps** 1. Submit a smart transactions (e.g., basic send on mainnet) 2. Go to the send flow and fill out the form for a swap+send 3. Ensure that the submit button is disabled with a tooltip: "A previous transaction is still being signed or submitted" 4. Ensure that the send flow is not reset to the recipient stage when the transactions complete 5. Ensure that a transaction can now be submitted as normal ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** See: #25349 <!-- [screenshots/recordings] --> ### **After** https://github.com/MetaMask/metamask-extension/assets/44588480/8f2b662c-2e55-433c-8c4a-50aaeb912d22 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information