refactor: reduce useDomainMismatchAlert dep

MetaMask · Jun 25, 2024 · 3771748 · 3771748
1 parent 834f68a
commit 3771748
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ui/pages/confirmations/hooks/alerts/signatures/useDomainMismatchAlert.ts b/ui/pages/confirmations/hooks/alerts/signatures/useDomainMismatchAlert.ts
@@ -22,10 +22,10 @@ export default function useDomainMismatchAlerts(): Alert[] {
   const { msgParams } = currentConfirmation || {};
 
   const isSIWE = isSIWESignatureRequest(currentConfirmation);
-  const isInvalidDomain = !isValidSIWEOrigin(msgParams as WrappedSIWERequest);
+  const isInvalidSIWEDomain = !isSIWE || !isValidSIWEOrigin(msgParams as WrappedSIWERequest);
 
   const alerts = useMemo(() => {
-    if (!isSIWE || !isInvalidDomain) {
+    if (!isInvalidSIWEDomain) {
       return [];
     }
 
@@ -38,7 +38,7 @@ export default function useDomainMismatchAlerts(): Alert[] {
         severity: Severity.Danger,
       },
     ] as Alert[];
-  }, [isSIWE, isInvalidDomain, t]);
+  }, [isInvalidSIWEDomain, t]);
 
   return alerts;
 }