Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Fix
AppMetadataController
tests (#25012)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AppMetadataController` tests were broken, but this was not discovered because they were never run. These tests were Mocha tests that were written in TypeScript, but we don't run Mocha on any TypeScript files. The tests have been fixed and migrated to Jest, so that they correctly run as part of our unit test suite. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25012?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** Run `yarn test:unit:jest` and find the `app-metadata` test results in the resulting test report and coverage report. ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information