Merge branch 'caip-multichain' into jl/caip-multichain/fix-connection…

…-flow-for-permittedChains
MetaMask · Oct 3, 2024 · 7915c28 · 7915c28
2 parents 1b4deb6 + 68db523
commit 7915c28
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 35 deletions.
diff --git a/app/scripts/lib/multichain-api/wallet-createSession/handler.js b/app/scripts/lib/multichain-api/wallet-createSession/handler.js
@@ -80,11 +80,6 @@ export async function walletCreateSessionHandler(req, res, _next, end, hooks) {
       isChainIdSupported: existsNetworkClientForChainId,
       isChainIdSupportable: existsEip3085ForChainId,
     });
-    // We assert if the unsupportable scopes are supported in order
-    // to have an appropriate error thrown for the response
-    assertScopesSupported(unsupportableRequiredScopes, {
-      isChainIdSupported: existsNetworkClientForChainId,
-    });
 
     const {
       supportedScopes: supportedOptionalScopes,

diff --git a/app/scripts/lib/multichain-api/wallet-createSession/handler.test.js b/app/scripts/lib/multichain-api/wallet-createSession/handler.test.js
@@ -285,36 +285,6 @@ describe('wallet_createSession', () => {
     expect(isChainIdSupportableBody).toContain('validScopedProperties');
   });
 
-  it('asserts any unsupported required scopes', async () => {
-    const { handler } = createMockedHandler();
-    bucketScopes.mockReturnValueOnce({
-      unsupportableScopes: {
-        'foo:bar': {
-          methods: [],
-          notifications: [],
-        },
-      },
-    });
-    await handler(baseRequest);
-
-    expect(assertScopesSupported).toHaveBeenNthCalledWith(
-      1,
-      {
-        'foo:bar': {
-          methods: [],
-          notifications: [],
-        },
-      },
-      expect.objectContaining({
-        isChainIdSupported: expect.any(Function),
-      }),
-    );
-
-    const isChainIdSupportedBody =
-      assertScopesSupported.mock.calls[0][1].isChainIdSupported.toString();
-    expect(isChainIdSupportedBody).toContain('findNetworkClientIdByChainId');
-  });
-
   it('buckets the optional scopes', async () => {
     const { handler } = createMockedHandler();
     validateAndFlattenScopes.mockReturnValue({