From a9b3601e7b0bc7f95555c65f26cf0e3aa8a19f8c Mon Sep 17 00:00:00 2001
From: David Walsh <davidwalsh83@gmail.com>
Date: Fri, 18 Oct 2024 09:04:02 -0500
Subject: [PATCH] test: Remove delays from onboarding tests

---
 test/e2e/tests/onboarding/onboarding.spec.js       |  8 --------
 test/e2e/tests/privacy/basic-functionality.spec.js | 11 -----------
 2 files changed, 19 deletions(-)

diff --git a/test/e2e/tests/onboarding/onboarding.spec.js b/test/e2e/tests/onboarding/onboarding.spec.js
index b5e273b7e978..de040f825ee6 100644
--- a/test/e2e/tests/onboarding/onboarding.spec.js
+++ b/test/e2e/tests/onboarding/onboarding.spec.js
@@ -20,8 +20,6 @@ const {
   onboardingCompleteWalletCreation,
   regularDelayMs,
   unlockWallet,
-  tinyDelayMs,
-  largeDelayMs,
 } = require('../../helpers');
 const FixtureBuilder = require('../../fixture-builder');
 const {
@@ -287,7 +285,6 @@ describe('MetaMask onboarding @no-mmi', function () {
           await driver.clickElement({
             text: 'General',
           });
-          await driver.delay(largeDelayMs);
           await driver.clickElement({ text: 'Add a network' });
 
           await driver.waitForSelector(
@@ -311,9 +308,7 @@ describe('MetaMask onboarding @no-mmi', function () {
           const rpcUrlInputDropDown = await driver.waitForSelector(
             '[data-testid="test-add-rpc-drop-down"]',
           );
-          await driver.delay(tinyDelayMs);
           await rpcUrlInputDropDown.click();
-          await driver.delay(tinyDelayMs);
           await driver.clickElement({
             text: 'Add RPC URL',
             tag: 'button',
@@ -371,7 +366,6 @@ describe('MetaMask onboarding @no-mmi', function () {
           await driver.clickElement(
             `[data-rbd-draggable-id="${toHex(chainId)}"]`,
           );
-          await driver.delay(largeDelayMs);
           // Check localhost 8546 is selected and its balance value is correct
           await driver.findElement({
             css: '[data-testid="network-display"]',
@@ -530,8 +524,6 @@ describe('MetaMask onboarding @no-mmi', function () {
         // pin extension walkthrough screen
         await driver.clickElement('[data-testid="pin-extension-next"]');
 
-        await driver.delay(regularDelayMs);
-
         for (let i = 0; i < mockedEndpoints.length; i += 1) {
           const mockedEndpoint = await mockedEndpoints[i];
           const isPending = await mockedEndpoint.isPending();
diff --git a/test/e2e/tests/privacy/basic-functionality.spec.js b/test/e2e/tests/privacy/basic-functionality.spec.js
index 6ae14ca660be..e45681534339 100644
--- a/test/e2e/tests/privacy/basic-functionality.spec.js
+++ b/test/e2e/tests/privacy/basic-functionality.spec.js
@@ -4,9 +4,6 @@ const {
   withFixtures,
   importSRPOnboardingFlow,
   WALLET_PASSWORD,
-  tinyDelayMs,
-  regularDelayMs,
-  largeDelayMs,
   defaultGanacheOptions,
 } = require('../../helpers');
 const { METAMASK_STALELIST_URL } = require('../phishing-controller/helpers');
@@ -65,8 +62,6 @@ describe('MetaMask onboarding @no-mmi', function () {
         });
         await driver.clickElement('[data-testid="category-item-General"]');
 
-        await driver.delay(regularDelayMs);
-
         await driver.clickElement(
           '[data-testid="basic-functionality-toggle"] .toggle-button',
         );
@@ -74,9 +69,7 @@ describe('MetaMask onboarding @no-mmi', function () {
         await driver.clickElement('[id="basic-configuration-checkbox"]');
         await driver.clickElement({ text: 'Turn off', tag: 'button' });
         await driver.clickElement('[data-testid="category-back-button"]');
-        await driver.delay(regularDelayMs);
         await driver.clickElement('[data-testid="category-item-Assets"]');
-        await driver.delay(regularDelayMs);
         await driver.clickElement(
           '[data-testid="currency-rate-check-toggle"] .toggle-button',
         );
@@ -114,7 +107,6 @@ describe('MetaMask onboarding @no-mmi', function () {
         await driver.clickElement('[data-testid="network-display"]');
 
         await driver.clickElement({ text: 'Ethereum Mainnet', tag: 'p' });
-        await driver.delay(tinyDelayMs);
 
         // Wait until network is fully switched and refresh tokens before asserting to mitigate flakiness
         await driver.assertElementNotPresent('.loading-overlay');
@@ -154,13 +146,10 @@ describe('MetaMask onboarding @no-mmi', function () {
           tag: 'button',
         });
         await driver.clickElement('[data-testid="category-item-General"]');
-        await driver.delay(largeDelayMs);
         await driver.clickElement('[data-testid="category-back-button"]');
-        await driver.delay(largeDelayMs);
         await driver.clickElement(
           '[data-testid="privacy-settings-back-button"]',
         );
-        await driver.delay(largeDelayMs);
         await driver.clickElement({ text: 'Done', tag: 'button' });
         await driver.clickElement('[data-testid="pin-extension-next"]');
         await driver.clickElement({ text: 'Done', tag: 'button' });