Skip to content

Commit

Permalink
chore: update BNB logos (#26140)
Browse files Browse the repository at this point in the history
## **Description**

Updates BNB network logo to the newly provided png and svg assets.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26140?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

Load app and validate that BNB chain logos are updated. Note that erc20
token logos will not update until
MetaMask/contract-metadata#1334 gets merged.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="300" alt="Screenshot 2024-07-25 at 10 20 48 AM"
src="https://github.com/user-attachments/assets/1657af96-71b3-4d53-9308-3b5d4127d960">

<img width="300" alt="Screenshot 2024-07-25 at 10 21 06 AM"
src="https://github.com/user-attachments/assets/cbda47bf-2dcb-481c-9530-6eda74b9b3e7">

<img width="300" alt="Screenshot 2024-07-25 at 10 22 32 AM"
src="https://github.com/user-attachments/assets/8be43670-298e-4b18-900f-3943eac4d310">

<img width="300" alt="Screenshot 2024-07-25 at 10 22 52 AM"
src="https://github.com/user-attachments/assets/10762e9f-c0ce-4871-964b-10e0d2112e82">

### **After**

<img width="300" alt="Screenshot 2024-07-25 at 10 38 18 AM"
src="https://github.com/user-attachments/assets/ab3ae389-6a68-451f-ae80-b4437343bf8b">
<img width="300" alt="Screenshot 2024-07-25 at 10 38 59 AM"
src="https://github.com/user-attachments/assets/80b66ffa-1ad2-422f-86b7-852b6e3b3555">
<img width="300" alt="Screenshot 2024-07-25 at 10 39 52 AM"
src="https://github.com/user-attachments/assets/2239643d-401a-4ae8-9850-2495d0c28d69">
<img width="300" alt="Screenshot 2024-07-25 at 10 40 15 AM"
src="https://github.com/user-attachments/assets/0c549632-6a1b-4ba4-8bfc-e34b80752fd2">


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
gambinish authored Jul 25, 2024
1 parent 855dd80 commit b27dd2b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 19 deletions.
Binary file modified app/images/bnb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 2 additions & 19 deletions app/images/bnb.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit b27dd2b

Please sign in to comment.