Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: ✨ show a notification item in the settings page (#26843)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR introduces the `Notifications` option within the `settings page`. Clicking on this option will render the user to the `notifications/settings` page. Specifically: 1. If basic functionalities are not active, the option disappears from the menu 2. If notifications are not active, the user will still be redirected to the `notifications/settings page`, where they can enable them 3. If notifications are active, the user will access the `notifications/settings` page, where they can select their options [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26843?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** 1. Go to the settings page. 2. Find the `Notifications` option 3. Verify that the `Notifications` option links to the `notifications/settings` page 4. Verify that the `Notifications` option is hidden if basic functionalities are off ## **Screenshots/Recordings** ### **Before** <img width="1624" alt="Screenshot 2024-10-23 at 16 26 12" src="https://github.com/user-attachments/assets/c260ca28-536d-413b-862b-79deda5e70bb"> ### **After** <img width="1624" alt="Screenshot 2024-10-23 at 16 41 30" src="https://github.com/user-attachments/assets/99fb68d6-ace1-4ddd-a863-7b4e2e125074"> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information